Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-store): delete verifiable credential #634

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

simonas-notcat
Copy link
Contributor

@simonas-notcat simonas-notcat commented Jul 23, 2021

Fixes: #635

@simonas-notcat simonas-notcat requested a review from mirceanis July 23, 2021 09:41
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #634 (200720e) into next (88264db) will increase coverage by 10.20%.
The diff coverage is 71.12%.

@@             Coverage Diff             @@
##             next     #634       +/-   ##
===========================================
+ Coverage   67.58%   77.78%   +10.20%     
===========================================
  Files          62       78       +16     
  Lines        1530     2345      +815     
  Branches      247      424      +177     
===========================================
+ Hits         1034     1824      +790     
- Misses        400      519      +119     
+ Partials       96        2       -94     

@mirceanis mirceanis merged commit c7b0131 into next Jul 23, 2021
@mirceanis mirceanis deleted the feature/datastore-delete-vc branch July 23, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting stored VCs
2 participants