This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #88 +/- ##
===============================================
- Coverage 34.41% 33.55% -0.86%
===============================================
Files 246 242 -4
Lines 3185 3168 -17
Branches 224 228 +4
===============================================
- Hits 1096 1063 -33
- Misses 1977 1989 +12
- Partials 112 116 +4
Continue to review full report at Codecov.
|
gjgd
reviewed
Sep 23, 2019
packages/element-api/src/express/routes/sidetree/nodeInfo.spec.js
Outdated
Show resolved
Hide resolved
This was referenced Sep 23, 2019
gjgd
approved these changes
Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a mess, lots of things here.
Tried to get rid of firestore, succeeded, but performance hit was not worth it:
I was able to prove that replication works: https://github.com/pubkey/rxdb/blob/master/docs-src/replication.md
However, cloud functions require some different behavior, we need a better pattern for handling mobile, cloud function, and server sidetree database abstractions, see #87
Fixed storybook ui
fixed various dependency and linting issues
fixed various documentation issues
fixed a batch processing error that was caused by newer versions of firebase functions. We need a better way of handling batch processing, related to Batch processing in cloud functions sucks #87.
deleted a bunch of dead code.