Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

Release/element-lib-0.1.2 #88

Merged
merged 21 commits into from
Sep 24, 2019
Merged

Release/element-lib-0.1.2 #88

merged 21 commits into from
Sep 24, 2019

Conversation

OR13
Copy link
Collaborator

@OR13 OR13 commented Sep 21, 2019

This is a bit of a mess, lots of things here.

  1. Implemented and tested in both web and server and ipfs manager pattern to avoid gateway errors from infura

Tried to get rid of firestore, succeeded, but performance hit was not worth it:

I was able to prove that replication works: https://github.com/pubkey/rxdb/blob/master/docs-src/replication.md

However, cloud functions require some different behavior, we need a better pattern for handling mobile, cloud function, and server sidetree database abstractions, see #87

  1. Fixed storybook ui

  2. fixed various dependency and linting issues

  3. fixed various documentation issues

  4. fixed a batch processing error that was caused by newer versions of firebase functions. We need a better way of handling batch processing, related to Batch processing in cloud functions sucks #87.

  5. deleted a bunch of dead code.

@codecov-io
Copy link

codecov-io commented Sep 21, 2019

Codecov Report

Merging #88 into development will decrease coverage by 0.85%.
The diff coverage is 42.18%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #88      +/-   ##
===============================================
- Coverage        34.41%   33.55%   -0.86%     
===============================================
  Files              246      242       -4     
  Lines             3185     3168      -17     
  Branches           224      228       +4     
===============================================
- Hits              1096     1063      -33     
- Misses            1977     1989      +12     
- Partials           112      116       +4
Impacted Files Coverage Δ
...ackages/element-lib/src/adapters/database/index.js 100% <ø> (ø) ⬆️
...nts/SidetreeBatchFile/SidetreeBatchFile.stories.js 0% <0%> (ø) ⬆️
...nts/SidetreeOperation/SidetreeOperation.stories.js 0% <0%> (ø) ⬆️
packages/element-app/src/services/sidetree.js 0% <0%> (ø) ⬆️
...s/SidetreeAnchorFile/SidetreeAnchorFile.stories.js 0% <0%> (ø) ⬆️
...ckages/element-lib/src/sidetree/getTransactions.js 100% <100%> (ø) ⬆️
...s/element-api/src/express/routes/sidetree/index.js 65.57% <100%> (ø) ⬆️
packages/element-lib/src/sidetree/getNodeInfo.js 100% <100%> (+60%) ⬆️
...nt-lib/src/adapters/database/ElementRXDBAdapter.js 68.29% <40%> (-17.92%) ⬇️
...lement-lib/src/adapters/storage/storage-manager.js 58.69% <60%> (-26.68%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a0418...5d23cbb. Read the comment docs.

@OR13 OR13 requested a review from gjgd September 23, 2019 18:43
@OR13 OR13 merged commit 7cccec4 into development Sep 24, 2019
@OR13 OR13 deleted the release/element-lib-0.1.2 branch September 25, 2019 04:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants