Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run tests on windows #3270

Merged
merged 8 commits into from
Feb 11, 2025
Merged

chore: run tests on windows #3270

merged 8 commits into from
Feb 11, 2025

Conversation

aixaCode
Copy link
Collaborator

@aixaCode aixaCode commented Jan 31, 2025

What does this PR change?

This change changes the platform on which we run tests from Linux to Windows. We do not support Linux as a target platform, so why test on it?

How to test the changes?

  1. Launch the explorer
  2. Quickly check for obvious breakage

This change does not change the game itself, so if the build succeeded, it is probably fine.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@aixaCode aixaCode added do not merge force-build Used to trigger a build on draft PR labels Jan 31, 2025
@aixaCode aixaCode added do not merge force-build Used to trigger a build on draft PR and removed do not merge force-build Used to trigger a build on draft PR labels Jan 31, 2025
@aixaCode aixaCode added force-build Used to trigger a build on draft PR and removed force-build Used to trigger a build on draft PR labels Jan 31, 2025
@aixaCode aixaCode added force-build Used to trigger a build on draft PR and removed force-build Used to trigger a build on draft PR labels Feb 3, 2025
@dalkia dalkia added force-build Used to trigger a build on draft PR and removed force-build Used to trigger a build on draft PR labels Feb 10, 2025
Signed-off-by: Juan Ignacio Molteni <juanignaciomolteni@gmail.com>
@dalkia dalkia added force-build Used to trigger a build on draft PR and removed force-build Used to trigger a build on draft PR labels Feb 10, 2025
dalkia and others added 2 commits February 10, 2025 17:09
Rollback
Signed-off-by: Juan Ignacio Molteni <juanignaciomolteni@gmail.com>
@AnsisMalins AnsisMalins marked this pull request as ready for review February 11, 2025 12:24
@AnsisMalins AnsisMalins requested review from a team as code owners February 11, 2025 12:24
@aixaCode aixaCode merged commit 850a489 into dev Feb 11, 2025
16 of 23 checks passed
@aixaCode aixaCode deleted the chore/run-test-windows branch February 11, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force-build Used to trigger a build on draft PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants