Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notification redirect freezing avatar #3261

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

mihakrajnc
Copy link
Contributor

What does this PR change?

This fixes #2918 where the Explore panel was not being opened correctly from Notifications, blocking input / reopening the panel after teleporting.

How to test the changes?

  1. Launch the explorer
  2. Open notifications panel
  3. Click on a notification that redirects to backpack
  4. Go to Map and teleport somewhere
  5. Click on a notification again, explore panel should open instead of flashing and blocking input

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@mihakrajnc mihakrajnc requested review from a team as code owners January 30, 2025 18:19
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Fix verified on Windows and Mac. The issue no longer occurs, and the explore panel opens correctly without flashing or blocking input.

Smoke test performed covering Essential Functionality:

  • LogIn
  • Teleport
  • Notifications
  • Backpack (wearables and emotes)
  • Social interactions
fix3261.mp4

@mihakrajnc mihakrajnc merged commit 5b5701f into dev Jan 31, 2025
13 of 16 checks passed
@mihakrajnc mihakrajnc deleted the fix/notification-input-blocking branch January 31, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] Explorer | Notifications Redirect Freezes Avatar
3 participants