Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix photos hover animation #3250

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

RominaMarchetti
Copy link
Contributor

What does this PR change?

This PR was created to fix the hover animation of the photos: removes the scale on hover, erasing the issue of not seeing side of the outline when a photo is inside and next to mask edge (as happens in the Profile and in the Scene's Info Cards in the map). Also, replaces the texture which emulated an outline for a real outline. The final result is a neat hover animation which works in every context.

BEFORE
https://github.com/user-attachments/assets/105f4300-c4fa-4919-9ff4-f91635956f5d

Screenshots of the outline getting chopped in the map and profile card
Screenshot 2025-01-29 at 14 26 52
Screenshot 2025-01-29 at 14 27 05

AFTER
https://github.com/user-attachments/assets/7c7c5450-c2da-49bc-b8f4-98a22cb80a0d

How to test the changes?

  1. Launch the explorer
  2. Go to the gallery and hover any photo. Check the scale animation was removed and that the outline appears inside the photo edges instead of outside.
  3. Go to the map and open the info card of a scene which contains photos (Genesis Plaza, for example). Go to the photos section, then repeat the action from task 2.
  4. Open your profile card (if you don't have any public photo, set one as public). Go to the photos section, then repeat the action from task 2.

Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢Approved by QA. Fix verified on Windows and Mac. Hover animation issue resolved, outline now appears correctly inside photo edges.

3250-fix.mp4

@RominaMarchetti RominaMarchetti requested review from lorux0 and fcolarich and removed request for dalkia and anicalbano January 31, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants