Remove a reference to an asset that does not exist #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
lorenzo-ranciaffi
approved these changes
Jan 28, 2025
DafGreco
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Sanity check made on both platforms (Macos and Windows )
Windows check :
Camera reel / Gallery ✅
- Camera reel shortcuts
- Camera reel instructions
- Camera reel teleport
- Camera reel zoom in-out
- Camera movements
- Camera reel details
Sanity check made on this PR :
- Map
- Notifications
- Badges
- Gallery
- Camera functionality
- Teleport (dollhouse /the inn /metadynelabs / Genesis plaza bar)
- Backpack
- My profile card
- Emotes
- Skybox functionality
Camera reel/Gallery Macos : ✅
- Camera reel shortcuts
- Camera reel instructions
- Camera reel teleport
- Camera reel movements
- Camera reel details overview
- Camera reel profile update
Sanity check made on this PR
- Map
- Backpack
- Profile customization
- Emotes
- Teleport (dollhouse /the inn / metadynelabs)
- Skybox functionality
- My profile card
- Badges
- notifications
No new issues were found during this sanity check on this PR ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
I'm trying to cut down on the Git status pollution with this change. When entering play mode, Essentials.asset is modified to remove a reference to ReelGalleryContextMenuConfig, an asset that does not exist in the dev branch yet. I'm guessing a change to Essentials.asset was committed by mistake.
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md