Change the chat entry prefabs to how Super Scroll View wants them #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
AnsisMalins
commented
Jan 28, 2025
QThund
approved these changes
Jan 28, 2025
Ludmilafantaniella
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
✅ Tested on Windows and Mac.
I used emojis, tested the chat bubble toggle, sent messages with word limits, and verified the chat functionality in Genesis City and Worlds. Everything works as expected.
Smoke test completed on key features, with no new issues found. Approving!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Super Scroll View keeps modifying these prefabs whenever play mode is entered, and that is an annoyance. After reading its source code, I believe that these prefabs should be that way all along. This change commits that.
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md