Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update protocol to latest friend changes #3221

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

lorux0
Copy link
Collaborator

@lorux0 lorux0 commented Jan 27, 2025

What does this PR change?

Updates the protocol to latest main and fixes the friend service imports.

How to test the changes?

  1. Launch the explorer
  2. Check that the startup flow works as expected

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this is exactly what I did to have my branch compile 💪

@lorux0 lorux0 enabled auto-merge (squash) January 27, 2025 20:24
Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved by QA. PR verified on Mac and Windows. Start up flow works as expected, also a smoke test was performed covering:

  • LogIn/LogOut flow - switching accounts (there is an issue there but not related with this PR)
  • Backpack (emotes and wearables)
  • Camera - Camera Ga;llery
  • Teleport: Pravus, Metadyne, Game Expo, auto emote scene --> The Inn
  • Social Interactions (chat, emote sync, wearables sync, passport)

@lorux0 lorux0 merged commit afb7e41 into dev Jan 28, 2025
11 of 16 checks passed
@lorux0 lorux0 deleted the fix/update-protocol branch January 28, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants