feat: controls panel #3151
Merged
feat: controls panel #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
dalkia
reviewed
Jan 17, 2025
dalkia
approved these changes
Jan 20, 2025
RominaMarchetti
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Sidebar button is okay, while controls screen needs some adjustments:
- Title font is incorrect. Must be Inter semi-bold. Now it's using Unity's default font.
- Fix title, close button, and Decentraland logo X,Y margin. Is 30px for all.
- Close button container color looks to bright compared to the design in Figma. Let's set for normal and selected #FFFFFF 5%, highlighted #FFFFFF 20%
Fixed, thanks! |
d3c1cae to
fed8132
Compare
RominaMarchetti
approved these changes
Jan 20, 2025
That was quick 🤩 |
|
PR main check on Windows:
Sanity check performed on windows :
Evidence of the H command functionality : hcommand.mp4 |
Ludmilafantaniella
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
🟢 I tested this PR on Mac, verifying the launch process, sidebar controls panel, and shortcut functionality (H). Everything is working as expected. Approving!
Smoke test performed:
- General functionallity of Hotkey.
- Teleport using GP Carrousel, Map and chat coords. Scene visited: The Inn, Metagamimall, Metadynelabs
- Social interactions
- Backpack
- Emotes
- Quests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This adds the Controls panel to the main sidebar and a new hotkey (H) to open it.
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md