avoid layout rebuild for height calculation

Explorer/Assets/DCL/UI/GenericContextMenu/Controls/GenericContextMenuButtonWithTextView.cs

@@ -7,6 +7,7 @@ namespace DCL.UI.GenericContextMenu.Controls
 {
     public class GenericContextMenuButtonWithTextView : MonoBehaviour, IGenericContextMenuComponent
     {
+        [field: SerializeField] public RectTransform RectTransformComponent { get; private set; }
         [field: SerializeField] public Button ButtonComponent { get; private set; }
         [field: SerializeField] public TMP_Text TextComponent { get; private set; }
         [field: SerializeField] public Image ImageComponent { get; private set; }

Explorer/Assets/DCL/UI/GenericContextMenu/Controls/GenericContextMenuToggleView.cs

@@ -7,6 +7,7 @@ namespace DCL.UI.GenericContextMenu.Controls
 {
     public class GenericContextMenuToggleView : MonoBehaviour, IGenericContextMenuComponent
     {
+        [field: SerializeField] public RectTransform RectTransformComponent { get; private set; }
         [field: SerializeField] public ToggleView ToggleComponent { get; private set; }
         [field: SerializeField] public TMP_Text TextComponent { get; private set; }
 

Explorer/Assets/DCL/UI/GenericContextMenu/GenericContextMenuController.cs

@@ -64,7 +64,7 @@ protected override void OnViewShow()
 
         private void ConfigureContextMenu()
         {
-            viewInstance!.ControlsContainer.sizeDelta = new Vector2(inputData.Config.Width, viewInstance!.ControlsContainer.sizeDelta.y);
+            float totalHeight = 0;
 
             for (var i = 0; i < inputData.Config.ContextMenuSettings.Count; i++)
             {
@@ -75,22 +75,30 @@ private void ConfigureContextMenu()
                 switch (config.ControlTypeType)
                 {
                     case ContextMenuControlTypes.SEPARATOR:
-                        controlsPoolManager.GetSeparator(config as SeparatorContextMenuControlSettings, i);
+                        GenericContextMenuSeparatorView separatorView = controlsPoolManager.GetSeparator(config as SeparatorContextMenuControlSettings, i);
+                        totalHeight += separatorView.RectTransformComponent.rect.height;
                         break;
                     case ContextMenuControlTypes.BUTTON_WITH_TEXT_AND_ICON:
                         GenericContextMenuButtonWithTextView button = controlsPoolManager.GetButton(config as ButtonContextMenuControlSettings, i);
                         button.ButtonComponent.onClick.AddListener(new UnityAction((Action)inputData.ControlsActions[i]));
                         button.ButtonComponent.onClick.AddListener(TriggerContextMenuClose);
+                        totalHeight += button.RectTransformComponent.rect.height;
                         break;
                     case ContextMenuControlTypes.TOGGLE_WITH_TEXT:
                         GenericContextMenuToggleView toggle = controlsPoolManager.GetToggle(config as ToggleContextMenuControlSettings, controlInitialValue != null && (bool)controlInitialValue , i);
                         toggle.ToggleComponent.Toggle.onValueChanged.AddListener(new UnityAction<bool>((Action<bool>)inputData.ControlsActions[i]));
                         toggle.ToggleComponent.Toggle.onValueChanged.AddListener(toggleValue => TriggerContextMenuClose());
+                        totalHeight += toggle.RectTransformComponent.rect.height;
                         break;
                 }
             }
-            Canvas.ForceUpdateCanvases();
-            LayoutRebuilder.ForceRebuildLayoutImmediate(viewInstance!.ControlsContainer);
+
+            viewInstance!.ControlsContainer.sizeDelta = new Vector2(inputData.Config.Width,
+                totalHeight
+                + viewInstance!.ControlsLayoutGroup.padding.bottom
+                + viewInstance!.ControlsLayoutGroup.padding.top
+                + (viewInstance!.ControlsLayoutGroup.spacing * (inputData.Config.ContextMenuSettings.Count - 1)));
+
             viewInstance!.ControlsContainer.localPosition = GetControlsPosition(inputData.AnchorPosition, inputData.Config.OffsetFromTarget, inputData.OverlapRect);
         }
 

Explorer/Assets/DCL/UI/GenericContextMenu/GenericContextMenuView.cs

@@ -8,6 +8,7 @@ namespace DCL.UI.GenericContextMenu
     public class GenericContextMenuView : ViewBase, IView, IDisposable
     {
         [field: SerializeField] public RectTransform ControlsContainer { get; private set; }
+        [field: SerializeField] public VerticalLayoutGroup ControlsLayoutGroup { get; private set; }
         [field: SerializeField] public Button BackgroundCloseButton { get; private set; }
 
         public event Action BackgroundCloseButtonClicked;

Explorer/Assets/DCL/UI/GenericContextMenu/Prefabs/ButtonWithTextAndIcon.prefab

@@ -346,6 +346,7 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: d0cb01ddb93349c98fd84395a98b77f9, type: 3}
   m_Name: 
   m_EditorClassIdentifier: 
+  <RectTransformComponent>k__BackingField: {fileID: 5856922699228769623}
   <ButtonComponent>k__BackingField: {fileID: 4754064954679370281}
   <TextComponent>k__BackingField: {fileID: 8655627310085805794}
   <ImageComponent>k__BackingField: {fileID: 6260016763612421407}

Explorer/Assets/DCL/UI/GenericContextMenu/Prefabs/GenericContextMenu.prefab

@@ -119,6 +119,7 @@ MonoBehaviour:
   <canvas>k__BackingField: {fileID: 6591100080399325240}
   <raycaster>k__BackingField: {fileID: 8522526520946479007}
   <ControlsContainer>k__BackingField: {fileID: 2932465032679087180}
+  <ControlsLayoutGroup>k__BackingField: {fileID: 5384044999603412779}
   <BackgroundCloseButton>k__BackingField: {fileID: 3243245791156245727}
 --- !u!1 &7170495978923432429
 GameObject:

Explorer/Assets/DCL/UI/GenericContextMenu/Prefabs/ToggleWithText.prefab

@@ -90,6 +90,7 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: e8f35c553d944f99854691517619b0e3, type: 3}
   m_Name: 
   m_EditorClassIdentifier: 
+  <RectTransformComponent>k__BackingField: {fileID: 891560713975722788}
   <ToggleComponent>k__BackingField: {fileID: 3675667337910807093}
   <TextComponent>k__BackingField: {fileID: 7042733739484598958}
 --- !u!1 &4204936758877281454