feat: move opcode counters to uint64 (#4)

* feat: move the counter to 64bit

* fix test

* increase mocha timeout

* fix prettier

package.json

@@ -30,9 +30,9 @@
     "tsc": "node_modules/.bin/tsc",
     "build": "make dist",
     "doc": "typedoc",
-    "test": "TS_NODE_TYPE_CHECK=false mocha",
-    "test-dist": "cd dist && TS_NODE_TYPE_CHECK=false mocha --require source-map-support/register *.test.js",
-    "test-fast": "TS_NODE_TYPE_CHECK=false TEST_NO_ASYNC=true mocha",
+    "test": "TS_NODE_TYPE_CHECK=false mocha --timeout 15000",
+    "test-dist": "cd dist && TS_NODE_TYPE_CHECK=false mocha --require source-map-support/register *.test.js  --timeout 15000",
+    "test-fast": "TS_NODE_TYPE_CHECK=false TEST_NO_ASYNC=true mocha --timeout 15000",
     "test-all": "TEST_LEAK=1 yarn test && yarn test-dist",
     "prettier": "prettier --write .",
     "prettier-check": "prettier --check .",

quickjs/quickjs.c

@@ -1258,17 +1258,14 @@ static const JSClassExoticMethods js_module_ns_exotic_methods;
 static JSClassID js_class_id_alloc = JS_CLASS_INIT_COUNT;
 
 
-uint32_t opcode_counter[256];
+uint64_t opcode_counter[256];
 
 void js_reset_opcode_counter() {
-    // TODO: move to memset
-    for (int i = 0; i < 256; i++) {
-        opcode_counter[i] = 0;
-    }
+    memset(opcode_counter, 0, 256 * 8);
 }
 
 
-uint32_t* js_get_opcode_counter() {
+uint64_t* js_get_opcode_counter() {
     return opcode_counter;
 }
 

quickjs/quickjs.h

@@ -379,7 +379,7 @@ void JS_AddIntrinsicOperators(JSContext *ctx);
 void JS_EnableBignumExt(JSContext *ctx, JS_BOOL enable);
 
 void js_reset_opcode_counter();
-uint32_t* js_get_opcode_counter();
+uint64_t* js_get_opcode_counter();
 
 
 JSValue js_string_codePointRange(JSContext *ctx, JSValueConst this_val,

ts/module-test.ts

@@ -80,4 +80,9 @@ export class TestQuickJSWASMModule implements Pick<QuickJSWASMModule, keyof Quic
   getFFI() {
     return this.parent.getFFI()
   }
+
+  /** @private */
+  getOpcodeInfo() {
+    return this.parent.getOpcodeInfo()
+  }
 }

ts/module.ts

@@ -24,6 +24,7 @@ import {
   RuntimeOptions,
   RuntimeOptionsBase,
 } from "./types"
+import { QuickJSOpcodeInfo } from "./opcodeinfo"
 
 type EmscriptenCallback<BaseArgs extends any[], Result> = (
   ...args: [Asyncify | undefined, ...BaseArgs]
@@ -322,12 +323,15 @@ export class QuickJSWASMModule {
   protected callbacks: QuickJSModuleCallbacks
   /** @private */
   protected module: EitherModule
+  /** @private */
+  protected opcodeInfo: QuickJSOpcodeInfo
 
   /** @private */
   constructor(module: EitherModule, ffi: EitherFFI) {
     this.module = module
     this.ffi = ffi
     this.callbacks = new QuickJSModuleCallbacks(module)
+    this.opcodeInfo = new QuickJSOpcodeInfo(module, ffi)
   }
 
   /**
@@ -429,4 +433,15 @@ export class QuickJSWASMModule {
   getFFI(): EitherFFI {
     return this.ffi
   }
+
+  /**
+   * Get a low-level interface to the QuickJS functions in this WebAssembly
+   * module.
+   * @experimental
+   * @unstable No warranty is provided with this API. It could change at any time.
+   * @private
+   */
+  getOpcodeInfo(): QuickJSOpcodeInfo {
+    return this.opcodeInfo
+  }
 }

ts/opcodeinfo.ts

@@ -0,0 +1,24 @@
+import { EitherModule } from "./emscripten-types"
+import { EitherFFI } from "./types"
+
+export class QuickJSOpcodeInfo {
+  private module: EitherModule
+  private ffi: EitherFFI
+
+  constructor(module: EitherModule, ffi: EitherFFI) {
+    this.module = module
+    this.ffi = ffi
+  }
+
+  public resetOpcodeCounters() {
+    this.ffi.QTS_ResetOpcodeCounter()
+  }
+
+  public getOpcodesCount() {
+    const opcodesArrayPtr = this.ffi.QTS_GetOpcodeCounter()
+    const values = new BigInt64Array(this.module.HEAP8.buffer, opcodesArrayPtr, 256)
+    const mappedArray = Array.from(values).map((count, opcode) => ({ count, opcode }))
+
+    return mappedArray.filter((item) => item.count > 0)
+  }
+}

ts/variants.ts

@@ -78,10 +78,6 @@ export async function newQuickJSWASMModule(
   wasmModule.type = "sync"
   const ffi = new QuickJSFFI(wasmModule)
 
-  // call once to compile it
-  ffi.QTS_ResetOpcodeCounter()
-  ffi.QTS_GetOpcodeCounter()
-
   return new QuickJSWASMModule(wasmModule, ffi)
 }