send binary message to specific address

[gonpombo8]

No description provided.

[github-actions]

Test this pull request

• The @dcl/protocol package can be tested in scenes by running

  npm install "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-12826974654.commit-3b9cde0.tgz"

[gonpombo8]

Suggested change

	message SendBinaryToAddress {
	message AddressedBinaryMessage ? {

[gonpombo8]

I dont like this name, maybe:

• targeted_messages
• private_messages
• targeted_messages
• address_messages

[gonpombo8]

is ok that this is an array of data ?

[kuruk-mm]

I think it should be bytes data = 1, not an array of bytes

[gonpombo8]

what if you reach the size limit for a single message and you need to send it in chunks

[kuruk-mm]

I would recommend the following messages:

message SendBinaryRequest {
  bytes data = 1; // broadcasted message
  repeated string addresses = 2; // when set, only forward to these identities
}

message SendBinaryResponse {}

This is based on the following:

https://github.com/livekit/protocol/blob/4aff238b1235618939dd10dd5aae21a776ad1b3c/protobufs/livekit_room.proto#L186C1-L197C2

If addresses is empty, it broadcasts the message for all peers.

I think it makes sense this way. WDYT?

[gonpombo8]

I would recommend the following messages:

message SendBinaryRequest {
  bytes data = 1; // broadcasted message
  repeated string addresses = 2; // when set, only forward to these identities
}

message SendBinaryResponse {}

This is based on the following:

https://github.com/livekit/protocol/blob/4aff238b1235618939dd10dd5aae21a776ad1b3c/protobufs/livekit_room.proto#L186C1-L197C2

If addresses is empty, it broadcasts the message for all peers.

I think it makes sense this way. WDYT?

We can't go with this approach the way the SDK is performed.
For every tick we call the sendBinary, and the response is the data that the client is sending to us.
So if you have multiple messages in a tick for different addresses, you need to call this twice, and it may affect the performance or some things on the client side.
In order to modify this the less, i prefer to be able to send multiple messages to differnet peers on a single request