Reordered properties to support different defaults on different messages

decentraland · Jan 30, 2025 · 35c385b · 35c385b
1 parent 64bf6eb
commit 35c385b
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/proto/decentraland/sdk/components/light_source.proto b/proto/decentraland/sdk/components/light_source.proto
@@ -6,23 +6,25 @@ import "decentraland/common/texture.proto";
 option (common.ecs_component_id) = 1079;
 
 message PBLightSource {
-  optional bool active = 4;                                           // default = true, whether the lightSource is active or not.
-  optional decentraland.common.Color3 color = 1;                      // default = Color.white, the tint of the light, in RGB format where each component is a floating point value with a range from 0 to 1.
-  optional float brightness = 2;                                      // default = 250, ranges from 1 (dim) to 100,000 (very bright), expressed in Lumens for Point and Spot.
-  optional float range = 3;                                           // default = 10, how far the light travels, expressed in meters.
-  optional ShadowType shadow = 5;                                     // default = ShadowType.ST_NONE The type of shadow the light source supports.
-  optional decentraland.common.TextureUnion shadow_mask_texture = 8;  // Texture mask through which shadows are cast to simulate caustics, soft shadows, and light shapes such as light entering from a window.
+  optional bool active = 4;                       // default = true, whether the lightSource is active or not.
+  optional decentraland.common.Color3 color = 1;  // default = Color.white, the tint of the light, in RGB format where each component is a floating point value with a range from 0 to 1.
+  optional float brightness = 2;                  // default = 250, ranges from 1 (dim) to 100,000 (very bright), expressed in Lumens for Point and Spot.
+  optional float range = 3;                       // default = 10, how far the light travels, expressed in meters.
 
   oneof type {
     Point point = 6;
     Spot spot = 7;
   }
 
-  message Point {}
+  message Point {
+    optional ShadowType shadow = 5; // default = ShadowType.ST_NONE The type of shadow the light source supports.
+  }
 
   message Spot {
-    optional float inner_angle = 1; // default = 21.8. Inner angle can't be higher than outer angle, otherwise will default to same value. Min value is 0. Max value is 179.
-    optional float outer_angle = 2; // default = 30. Outer angle can't be lower than inner angle, otherwise will inner angle will be set to same value. Max value is 179.
+    optional float inner_angle = 1;                                     // default = 21.8. Inner angle can't be higher than outer angle, otherwise will default to same value. Min value is 0. Max value is 179.
+    optional float outer_angle = 2;                                     // default = 30. Outer angle can't be lower than inner angle, otherwise will inner angle will be set to same value. Max value is 179.
+    optional ShadowType shadow = 5;                                     // default = ShadowType.ST_NONE The type of shadow the light source supports.
+    optional decentraland.common.TextureUnion shadow_mask_texture = 8;  // Texture mask through which shadows are cast to simulate caustics, soft shadows, and light shapes such as light entering from a window.
   }
 
   enum ShadowType {