Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove install of asset-pack #995

Merged
merged 1 commit into from
Sep 6, 2024
Merged

remove install of asset-pack #995

merged 1 commit into from
Sep 6, 2024

Conversation

gonpombo8
Copy link
Contributor

@gonpombo8 gonpombo8 commented Sep 5, 2024

@dcl/asset-packs is already installed inside the @dcl/inspector.
@dcl/inspector is installed via @dcl/sdk-commands
@dcl/sdk-commands is installed via @dcl/sdk

So there is no need to install the asset-packs again, is already there.
Also it fixes the unlink of npm packages every time you run npm start.

Copy link

cloudflare-workers-and-pages bot commented Sep 5, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6fd642b
Status: ✅  Deploy successful!
Preview URL: https://a5d7352e.js-sdk-toolchain.pages.dev
Branch Preview URL: https://remove-asset-pack.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/remove/asset-pack/dcl-sdk-7.5.8-10727602469.commit-819eb1b.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/remove/asset-pack/dcl-sdk-commands-7.5.8-10727602469.commit-819eb1b.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/remove/asset-pack/@dcl/inspector/dcl-inspector-7.5.8-10727602469.commit-819eb1b.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/remove/asset-pack-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=remove/asset-pack

@gonpombo8 gonpombo8 merged commit d6809c5 into main Sep 6, 2024
8 checks passed
@gonpombo8 gonpombo8 deleted the remove/asset-pack branch September 6, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants