Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: block player movement #991

Merged
merged 12 commits into from
Sep 4, 2024

Conversation

AlejandroAlvarezMelucciDCL
Copy link
Contributor

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL commented Aug 14, 2024

This PR is part of Cycle's 8 Shape Feature block player movement

Related PRs:

Protocol: #215
Explorer: #1777

Copy link
Contributor

github-actions bot commented Aug 14, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/block-player-movement/dcl-sdk-7.5.7-10687888608.commit-d0d25b1.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/block-player-movement/dcl-sdk-commands-7.5.7-10687888608.commit-d0d25b1.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/block-player-movement/@dcl/inspector/dcl-inspector-7.5.7-10687888608.commit-d0d25b1.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/block-player-movement-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/block-player-movement

…is one will be deleted after testing and choosing one.
Copy link

cloudflare-workers-and-pages bot commented Aug 19, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5cc066c
Status: ✅  Deploy successful!
Preview URL: https://e3f3bb6f.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-block-player-movement.js-sdk-toolchain.pages.dev

View logs

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.42%. Comparing base (fd35f3f) to head (9b497ca).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   65.32%   72.42%   +7.10%     
==========================================
  Files         561      157     -404     
  Lines       17207     5172   -12035     
  Branches     2171      914    -1257     
==========================================
- Hits        11240     3746    -7494     
+ Misses       5593     1292    -4301     
+ Partials      374      134     -240     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL marked this pull request as ready for review August 28, 2024 20:32
@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL merged commit f652672 into main Sep 4, 2024
8 checks passed
@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL deleted the feat/block-player-movement branch September 4, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants