Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: asset packs peer dep #1015

Merged
merged 1 commit into from
Oct 2, 2024
Merged

chore: asset packs peer dep #1015

merged 1 commit into from
Oct 2, 2024

Conversation

cazala
Copy link
Contributor

@cazala cazala commented Oct 2, 2024

Upgrade @dcl/asset-packs to version that removes @dcl/ecs from its dependencies

Copy link

cloudflare-workers-and-pages bot commented Oct 2, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 123631c
Status: ✅  Deploy successful!
Preview URL: https://c5c364cd.js-sdk-toolchain.pages.dev
Branch Preview URL: https://chore-asset-packs-peer-dep.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/asset-packs-peer-dep/dcl-sdk-7.6.1-11151485569.commit-7e5b1d7.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/asset-packs-peer-dep/dcl-sdk-commands-7.6.1-11151485569.commit-7e5b1d7.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/asset-packs-peer-dep/@dcl/inspector/dcl-inspector-7.6.1-11151485569.commit-7e5b1d7.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/chore/asset-packs-peer-dep-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=chore/asset-packs-peer-dep

@cazala cazala marked this pull request as ready for review October 2, 2024 20:54
@cazala cazala force-pushed the chore/asset-packs-peer-dep branch from 812e56e to 123631c Compare October 2, 2024 20:56
@cazala cazala enabled auto-merge (squash) October 2, 2024 20:59
@cazala cazala merged commit 2a0de2c into main Oct 2, 2024
8 checks passed
@cazala cazala deleted the chore/asset-packs-peer-dep branch October 2, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants