Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastapi example & schema refactor & update Makefile and README #34

Merged
merged 5 commits into from
Jul 20, 2023
Merged

fastapi example & schema refactor & update Makefile and README #34

merged 5 commits into from
Jul 20, 2023

Conversation

XeniaLu
Copy link
Member

@XeniaLu XeniaLu commented Jul 14, 2023

No description provided.

@XeniaLu XeniaLu changed the title fastapi example WIP: fastapi example Jul 14, 2023
@XeniaLu XeniaLu changed the title WIP: fastapi example fastapi example & schema refactor & update Makefile and README Jul 17, 2023
@XeniaLu XeniaLu requested a review from daichen-daisy July 17, 2023 08:59
@daichen-daisy
Copy link
Member

I only took a look because it's totally over my big head :D. I will leave it to @fantix to review.

@XeniaLu XeniaLu requested review from fantix and removed request for daichen-daisy July 19, 2023 01:45
fantix
fantix approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we should also have a sample login in the example.

@XeniaLu
Copy link
Member Author

XeniaLu commented Jul 20, 2023

LGTM! I think we should also have a sample login in the example.

Sure, I will add it later. @fantix

@XeniaLu XeniaLu merged commit 4ce432a into decentfox:main Jul 20, 2023
@XeniaLu XeniaLu deleted the build-package branch July 20, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantix fantix fantix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XeniaLu @daichen-daisy @fantix