feat(nested collections) legacy mode #7387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fgnass since you were the last person that worked on this code, I'd be grateful if you took a glance and let me know if you have any comments |
martinjagodic
previously approved these changes
Jan 31, 2025
|
The default state of the subfolders flag is now true, so unless specifically set to false, this will work as it did before. I have update the tests to test the new feature by passing the subfolders: false |
martinjagodic
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In response to #7384 I'm proposing a (possibly temporary) solution for collections that use the subdirectory based nested structures (changes introduced in #7359 / #6498)
This PR adds an opt-out switch to the nested configuration object.
@martinjagodic suggested
subfoldersas the name, but we can change it if we find a better idea. Personally, I'm leaning into something that better indicates which mode is preferred for new projects.Test plan
The best way to test this is by using the configuration provided in #7384 and turning subfolders on/off.
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)