-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: make Add To Your Site into pages #7064
Docs: make Add To Your Site into pages #7064
Conversation
❌ Deploy Preview for decap-www failed.
|
Great point @privatemaker. Can you please merge the 2 overviews? The platform guide doesn't need an overview page IMO. On a side note, it's a bit confusing that we have several pages named Overview. We could solve this by adding the section name to the title, like Account Settings Overview. Your opinion? |
I'm glad you agree with my instincts 🥳 I also found multiple I've pushed a change with the first in Additionally, there are some parts in |
Also, this should have a redirect from /docs/add-to-your-site to the new |
@martinjagodic what is your thoughts on these changes? Anything else you'd like me to do? |
@privatemaker sorry to keep you waiting. This is way better, but I miss a step navigation now. Either on the bottom or by the side or whatever, just to make the user feel that this is one tutorial. I want to discuss this with the team internally before merging. I will get back to you next week on this. If you have any ideas please share 😊 |
@martinjagodic re: missing "a step navigation now." I see what you mean. There is actually some confusion on this as the terms in my Here is what I propose:
I think that will give it more of a walk through experience, which as you point out (and I agree) is very much needed. If this sounds good, I can get to this later in the week. |
@privatemaker this is very similar to what I had in mind, so I agree with all your proposals. Please, go ahead. |
Ok cool. These changes are now done. Note: I think buttons would be nicer than text links at the bottom of the page, but I'm not sure how easy that is in this site's Gatsby setup. |
I agree about the buttons. The site does not support MDX, so components can't be used. But you can use HTML and we can work with that. In In essence, this will work: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this could look better, but we have to work with what we have here. As mentioned in another discussion I will move the website to its own repo, and we can work on improving that there.
@privatemaker your batch of contributions to the docs are a major improvement, I thank you on behalf of the community. 🙏
@martinjagodic I'm really glad to have helped out. It will also make my work time referencing the docs easier... 😄 |
Starting on #7051 I split up the four sections on
add-to-your-site.md
In the process of this, I realized some related things:
The Platform Guides Overview page seems like it belongs better as the
Overview
forAdd To Your Site
group, as it really gives a more general overview vs. specific to static site generators.In fact, that page does not say anything about SSGs so it is odd that it is down there.