Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs: migrate Beta Features - Editorial Workflow #7044

Merged

Conversation

privatemaker
Copy link
Contributor

Continuing migration of Beta Features Documentation #7040

@martinjagodic slightly cleaner this time- last one was made editing within Decap and merging 🥲

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for decap-www ready!

Name Link
🔨 Latest commit 13ff175
🔍 Latest deploy log https://app.netlify.com/sites/decap-www/deploys/65af83e6f2d6d20008708951
😎 Deploy Preview https://deploy-preview-7044--decap-www.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@privatemaker
Copy link
Contributor Author

Or perhaps this should go in the Workflow group?

@martinjagodic
Copy link
Member

I vote for the workflow group.

@privatemaker privatemaker requested a review from a team as a code owner January 19, 2024 12:47
@privatemaker
Copy link
Contributor Author

Ok. This is now in Workflow Group. I reworked the text a little bit.

Copy link
Member

@martinjagodic martinjagodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@privatemaker
Copy link
Contributor Author

I removed the whitespace!

@privatemaker
Copy link
Contributor Author

While combing through the docs, I noticed this feature is also mentioned in two other places which cross link to one-another and repeat information which is also (now) getting it's own page with this pull-req.

I think this should be simplified with both of those sections mentioning and linking to the newly created page.

@martinjagodic
Copy link
Member

I agree, can you do that as part of this PR?

@privatemaker
Copy link
Contributor Author

Yep. I've done what I think makes most sense in terms of consolidating and trimming. By my eye this is ready for merging.

Copy link
Member

@martinjagodic martinjagodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except that link.

website/content/docs/editorial-workflows.md Outdated Show resolved Hide resolved
@martinjagodic martinjagodic enabled auto-merge (squash) January 23, 2024 09:17
@martinjagodic martinjagodic merged commit f26ae53 into decaporg:master Jan 23, 2024
16 checks passed
@privatemaker privatemaker deleted the docs/beta-features/editorial-flow branch January 23, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants