Convert function expressions to declarations #4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 7, 2021 22:24
…ction declarations
… function declarations
…nction declarations
…s to function declarations
…o function declarations
…unction declarations
…o function declarations
…function declarations
…function declarations
…function declarations
…function declarations
…nction declarations
…unction declarations
…nction declarations
…ction declarations
…o function declarations
…nction declarations
…nction declarations
…on expressions to function declarations
…on expressions to function declarations
…pressions to function declarations
…n expressions to function declarations
…xpressions to function declarations
…xpressions to function declarations
…ion expressions to function declarations
added 5 commits
February 7, 2021 22:42
…pressions to function declarations
…ressions to function declarations
…sions to function declarations
…nction declarations
|
Some links to validate the change: |
erezrokah
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addressing #4846 (comment)
Make function syntax consistent across the whole codebase
Test plan
Just run current tests