Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs: Account “external-oauth-clients” #4893

Conversation

deepbass
Copy link
Contributor

Automatically generated by Netlify CMS

@deepbass deepbass requested a review from a team January 30, 2021 21:18
@deepbass
Copy link
Contributor Author

Hi, apologies if this doesn't fit the required structure. I was experimenting with adding my Azure-based External OAuth Client and didn't clock that this would send in a PR!

@erezrokah erezrokah self-requested a review February 1, 2021 10:44
@erezrokah erezrokah force-pushed the cms/deepbass/netlify-cms/docs_accounts/external-oauth-clients branch from dbde750 to ab8378a Compare February 7, 2021 11:49
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deepbass, very cool to have an Azure OAuth client.
One question though - will users need to update the base_url address after deploy their function here. I'm referring to the following line in config.yml
https://github.com/deepbass/serverless-cms-azure/blob/ca9b3d22c667882dbd0e33e315638c15d91a2a43/static/admin/config.yml#L5

If so, can we clarify that in the README? Otherwise I believe users will authenticate with your GitHub OAuth app.

@deepbass
Copy link
Contributor Author

deepbass commented Feb 7, 2021

Hi @erezrokah, thanks for taking a look! I've put in a change to highlight that in my readme, the diff is highlighted here: https://github.com/deepbass/serverless-cms-azure/pull/3/files

@erezrokah
Copy link
Contributor

Hi @erezrokah, thanks for taking a look! I've put in a change to highlight that in my readme, the diff is highlighted here: https://github.com/deepbass/serverless-cms-azure/pull/3/files

Nice touch with the repo comment too :)

@erezrokah erezrokah merged commit 319a538 into decaporg:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants