Remove immutable from status and auth #4727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smashercosmo
commented
Dec 15, 2020
|
|
||
| const auth = (state = defaultState, action: AuthAction) => { | ||
| const auth = produce((draft: Auth, action: AuthAction) => { |
There was a problem hiding this comment.
Hm... maybe it's better to use 'state' instead of 'draft'
|
Hm... seems like something's not ok |
|
@erezrokah any idea why e2e tests are failing? |
|
Alright, found the reason |
3245e90 to
c3d7a97
Compare
erezrokah
approved these changes
Dec 20, 2020
vladdu
pushed a commit
to vladdu/netlify-cms
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First step on closing #3853
Test plan
Run existing tests