-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix frontmatter stringification for date fields #384
Conversation
Switches back to custom frontmatter stringification until support lands in preliminaries. This is necessary because we use custom schemas for certain data types, such as dates and times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and fixes the issue on my test repo.
EDIT: looks like a test needs to be updated; the Travis build is failing.
👍 good idea |
Another option is to pass a custom parser implementation that wraps the existing YAML to preliminaries:
|
I like @josephearl's suggestion. |
@erquhart @calavera @josephearl I have the tests passing (mocked |
Thanks @Benaiah. LGTM |
@josephearl can you update to use our custom parser with preliminaries? Otherwise I will when I get back online. |
Closing in favor of #385, which uses the implementation suggested by @josephearl. |
Switches back to custom frontmatter stringification
until support lands in the preliminaries lib. This is necessary
because we use custom schemas for certain data types,
such as dates and times.
- Summary
Date fields can no longer be changed through the CMS. Regression from #348.
- Test plan
Moved the Published Date field in the example project out of metadata and into standard fields, so persisting dates can be observed in deploy previews. Tested locally.
- Description for the changelog
Fix date/datetime field persisting