WIP - Force trailing slash #352
Conversation
src/index.js
Outdated
| document.body.appendChild(el); | ||
| const fixUrl = (pathname) => { | ||
| window.location.href = | ||
| `${ window.location.protocol }//${ window.location.host }${ pathname }` |
There was a problem hiding this comment.
Nitpick: we can shrink this down by first destructuring window.location.
src/index.js
Outdated
| const el = document.createElement('div'); | ||
| el.id = 'root'; | ||
| document.body.appendChild(el); | ||
| const fixUrl = (pathname) => { |
There was a problem hiding this comment.
I agree with your mention of placement - it would be good to put this somewhere route specific, and try to involve React Router if possible. I like this approach. We could then put the rewriting functions in a separate file under src/routing. What do you think?
There was a problem hiding this comment.
Thanks, will take a look at the react router solution you linked and see if I can do it that way
There was a problem hiding this comment.
I gave this a go (see new commit) -- but unfortunately it didn't work - if you have a URL http://localhost/admin, http://localhost/admin/ or http://localhost/admin// the path is / as far React router is concerned.
|
@erquhart thanks for the title update - I had been meaning to do that! |
|
Closing this - considering that we don't know where folks will put the CMS and how their build system will interact with it, we'll need a more considered approach to solve this issue (if at all). |
- Summary
Attempt at fixing #332 with React Router, does not work currently. Needs further investigation.
- Description for the changelog
If the path name does not end in a single trailing slash when the app is loaded redirect to a URL with a single trailing slash before loading the rest of the app.