Prevent giant images in editor #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Discovered that large images inserted in the markdown editor expand beyond the borders of the editor, making them a hassle to scroll past.
I added the common global default
img { max-width: 100%; }to prevent this and other similar layout bugs that may come up in the future.- Test plan
Quick-and-dirty testing with the web inspector showed the problem solved and no other layout bugs as a result.
- Description for the changelog
Prevent images from overflowing their containers
- A picture of a cute animal (not mandatory but encouraged)
(my pups, Monty and Petunia) 😄
