Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netlify-cms-core): fix prop-types warnings #1906

Merged
merged 1 commit into from
Nov 26, 2018
Merged

fix(netlify-cms-core): fix prop-types warnings #1906

merged 1 commit into from
Nov 26, 2018

Conversation

alexandernanberg
Copy link
Contributor

Summary

Removes/fixes these warnings

image

Test plan

No warnings shown in the console

@verythorough
Copy link
Contributor

Deploy preview for cms-demo ready!

Built with commit e3862fd

https://deploy-preview-1906--cms-demo.netlify.com

@verythorough
Copy link
Contributor

Deploy preview for netlify-cms-www ready!

Built with commit e3862fd

https://deploy-preview-1906--netlify-cms-www.netlify.com

@erquhart
Copy link
Contributor

Nice, glad someone finally got to these 👍

@erquhart erquhart merged commit 751ec09 into decaporg:master Nov 26, 2018
@alexandernanberg alexandernanberg deleted the fix/prop-types-warnings branch November 26, 2018 17:16
LoicMahieu added a commit to LoicMahieu/netlify-cms that referenced this pull request Nov 29, 2018
* official/master: (42 commits)
  chore: improve publish scripts
  Publish
  chore: test before publishing
  chore(netlify-cms-core): upgrade react-dnd to 7.x (decaporg#1922)
  chore(netlify-cms-widget-text): upgrade to react-textarea-autosize 7.x (decaporg#1921)
  chore(netlify-cms-core): upgrade to react-waypoint 8.x (decaporg#1920)
  fix(backend): use singular label in custom commit message (decaporg#1917)
  docs: add GAE-specific oAuth client (decaporg#1918)
  fix(netlify-cms-widget-text): set correct font family (decaporg#1916)
  chore(netlify-cms-core): upgrade redux and related dependencies (decaporg#1914)
  chore(dependencies): bump npm-run-all (decaporg#1913)
  fix(netlify-cms-core): fix identifier field validation (decaporg#1907)
  docs: improve widget custom validation sample (decaporg#1911)
  improvement(backends): changes for registerBackend compatibility (decaporg#1880)
  fix(netlify-cms-core): fix prop-types warnings (decaporg#1906)
  fix(a11y): correct label "for" references to fields (decaporg#1904)
  improvement(netlify-cms-core): wrap navigations in lists for better a11y (decaporg#1903)
  fix(netlify-cms-widget-markdown): add missing border radius on toolbar (decaporg#1905)
  fix(netlify-cms-core): remove double focusable elements on profile menu button (decaporg#1900)
  fix(config): remove identifier field validation (decaporg#1882)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants