-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Viewer mode #642
Add Viewer mode #642
Conversation
Added --viewer command line argument Changed ViewDataShell to behave slightly differently depending on whether it is being called as admin or viewer
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## develop #642 +/- ##
===========================================
- Coverage 99.10% 99.07% -0.04%
===========================================
Files 64 64
Lines 6054 6071 +17
===========================================
+ Hits 6000 6015 +15
- Misses 54 56 +2
Continue to review full report at Codecov.
|
Thanks @robintw - could you have a think about what changes should be made to I'm pretty sure we should include the new command line parameters, but there may be a need for some higher level content - such as introducing the concept of the viewer. |
@robintw - it looks like there is an issue with Create Deployment. Maybe prompt_toolkit has moved. |
This create_deployment issue seemed to be an issue with installing black using the latest version of pip. Pip have released a new version (20.3) today, which switches to a new package resolver which is a lot more strict than the previous version. Pip was checking the metadata for the black package it had downloaded and raised an error as some of the metadata versions didn't match. This only seems to occur on the embedded version of Python we use in the Windows deployment, not on a normal Windows Python. This has been temporarily solved by pinning black to an older version in I've raised an issue on the black Github repo at psf/black#1847. I have a suspicion they're going to tell me it's pip's problem, so I might end up raising an issue for pip too. I'll keep an eye on it all and let you know what happens. As part of investigating this, I've noticed that failures in running the actual |
Argh, ignore that - pinning to an older black version means black wants to reformat all of our files! I'll work on this more tomorrow. |
… legacy pip resolver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ❤️ the viewer logo.
🧰 Issue
#610
🚀 Overview:
Adds a new Pepys Viewer app, which only provides access to the View Data commands within Pepys Admin. This can be called from the command-line using
--viewer
, or from two new Start Menu shortcuts:Pepys Viewer
andPepys Viewer (training mode)
.🤔 Reason:
For some users, we wish to let them use Pepys-Admin to view data, but not to have access (or require training in) the rest of the Admin operations.
🔨Work carried out:
🖥️ Screenshot
Confirmations
📝 Developer Notes:
This depends on #624, and that should be merged first. I have already merged in the branch for #624 into this branch, as they were both modifying lots of the same files and I needed to sort out all the conflicts. Hopefully Github will do the sensible thing and only show the new commits here, once #624 is merged.