-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the conda forge implementation on the vnu-validator #17
Conversation
A preview fo the exported examples will be rendered at |
Meanwhile, and unfortunately not supported particularly well with the custom There's the beginning of this in the feedstock test suite, though it is incomplete:
I think the goal would be a some
TVnuRequestFactory = Callable[[dict], dict]
def test_use_vnu(vnu_api: TVnuRequestFactory):
vnu_res = make_a_vnu_request({"file": some_html_file.read_text()})
assert vnu_res["violations"] |
so is the short term to ship the inefficient solution and work on the tests themselves then handle the server in another go? |
I think on an infrastructure PR, it might be worth going the extra mile to get that per-test time down. I'll take a look. |
thanks bro. i think one of the features of the vnu validator is that it just needs to be run as one shot. where axe and others depend on the page state, vnu can check in a single pass. so likely that will reduce the number of web servers required for these specific checks |
Recommend running/pushing https://github.com/deathbeds/nbconvert-a11y/pull/19/files |
Also, noted from #19:
|
@bollwyvl created a feedstock for the w3c vnu validator. this pull request integrates that effort instead of the hand rolled installation we use now.
lets have this PR only focus on CI and i'll make another PR that creates a pytest fixture for the validator assuming
vnu-validator
is installed with conda.ref: conda-forge/staged-recipes#24509