Skip to content

Commit

Permalink
Minor corrections
Browse files Browse the repository at this point in the history
* Type hints missing
* Unused property
  • Loading branch information
deanblackborough committed Dec 4, 2017
1 parent 06d58e5 commit 5e54b1a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/Bootstrap4Alert.php
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public function setBgStyle(string $color) : Bootstrap4Alert
*
* @return Bootstrap4Alert
*/
public function setHeading(string $heading, $heading_level = 4) : Bootstrap4Alert
public function setHeading(string $heading, int $heading_level = 4) : Bootstrap4Alert
{
$this->heading = $heading;
$this->heading_level = $heading_level;
Expand Down
4 changes: 2 additions & 2 deletions src/Bootstrap4Button.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public function __invoke(string $label): Bootstrap4Button
*
* @return Bootstrap4Button
*/
public function setBgStyle($color) : Bootstrap4Button
public function setBgStyle(string $color) : Bootstrap4Button
{
$this->assignBgStyle($color);

Expand Down Expand Up @@ -130,7 +130,7 @@ public function setOutlineStyle(string $style): Bootstrap4Button
*
* @return Bootstrap4Button
*/
public function setTextStyle($color) : Bootstrap4Button
public function setTextStyle(string $color) : Bootstrap4Button
{
$this->assignTextStyle($color);

Expand Down
4 changes: 2 additions & 2 deletions src/Bootstrap4Card.php
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ public function setHeader(string $content) : Bootstrap4Card
*
* @return Bootstrap4Card
*/
public function setBgStyle($color) : Bootstrap4Card
public function setBgStyle(string $color) : Bootstrap4Card
{
$this->assignBgStyle($color);

Expand All @@ -582,7 +582,7 @@ protected function assignBgStyle(string $color)
*
* @return Bootstrap4Card
*/
public function setTextStyle($color) : Bootstrap4Card
public function setTextStyle(string $color) : Bootstrap4Card
{
$this->assignTextStyle($color);

Expand Down
4 changes: 2 additions & 2 deletions src/Bootstrap4Jumbotron.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function fluid() : Bootstrap4Jumbotron
*
* @return Bootstrap4Jumbotron
*/
public function setBgStyle($color) : Bootstrap4Jumbotron
public function setBgStyle(string $color) : Bootstrap4Jumbotron
{
$this->assignBgStyle($color);

Expand Down Expand Up @@ -112,7 +112,7 @@ public function setHeadingDisplayLevel(int $level) : Bootstrap4Jumbotron
*
* @return Bootstrap4Jumbotron
*/
public function setTextStyle($color) : Bootstrap4Jumbotron
public function setTextStyle(string $color) : Bootstrap4Jumbotron
{
$this->assignTextStyle($color);

Expand Down
1 change: 0 additions & 1 deletion src/Bootstrap4ProgressBarMultiple.php
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ private function reset(): void
$this->bg_colors = [];
$this->striped = false;
$this->animate = false;
$this->label = null;
$this->height = null;
}

Expand Down

0 comments on commit 5e54b1a

Please sign in to comment.