New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace content encoding negotiation and fix Brotli compression #1

Merged

cecchi merged 2 commits into master from accept-negotiation

Feb 27, 2019

cecchi commented Feb 27, 2019 •

edited

Loading

The current library used for content-encoding negotiation will never pick br in practice, at least for many major browsers (see: Change resolved Accept-Encoding to honour server side order preferece jshttp/negotiator#49). Replacing it with accept gets us the desired behavior.
The upstream of this fork has a typo and uses the Brotli decompression method instead of the compression method, which causes the server to throw and crash.

cecchi added 2 commits

February 26, 2019 17:15


          fix: replace "accepts" with "accept" for content encoding negotiation

9c3260c


          fix: use createBrotliCompress, not createBrotliDecompress

f5e8143

cecchi merged commit bd24382 into master

cecchi deleted the accept-negotiation branch

February 27, 2019 01:29

dealinfra commented Feb 27, 2019

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

dealinfra added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels