Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Fix develop branch deadbot call #66

Closed
wants to merge 4 commits into from

Conversation

B13rg
Copy link
Contributor

@B13rg B13rg commented Oct 4, 2024

Makes the following changes:

  • fix how main.sh calls various deadbot functions
  • added parenthesis around parameter logic
  • soften localization exception

@B13rg
Copy link
Contributor Author

B13rg commented Oct 4, 2024

For the parser.py changes, I kept hitting it (maybe a python 3.12 thing?) so I softened it to a warning. With the assignment added, I get a clean diff when ran against files

@B13rg B13rg mentioned this pull request Oct 4, 2024
@hassayag
Copy link
Member

hassayag commented Oct 4, 2024

For the parser.py changes, I kept hitting it (maybe a python 3.12 thing?) so I softened it to a warning. With the assignment added, I get a clean diff when ran against files

Ah I am on 3.11 and so is the project in general, see if that helps? But not sure why that would be a problem in this case 🤔

@B13rg
Copy link
Contributor Author

B13rg commented Oct 4, 2024

Actually, I think the changes in #53 will fix this better for main.sh, it finishes parameterizing all the functions and cleaning up that interface.

@B13rg B13rg closed this Oct 4, 2024
@B13rg B13rg deleted the bugfix/develop-deadbot-call branch October 4, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants