Bugfix/misc changelog fixes #154
Conversation
We still want to remap tags to self.default_tag for standardization, but we don't want to link to the default tag as its not going to function as a tag you filter down to
…iki/deadbot into bugfix/tag-reordering
This reverts commit 507cc50.
|
Converted it to a draft earlier while I added some other minor corrections, its back to ready for review now |
| 'link': None, | ||
| 'is_hero_lab': True, | ||
| 'is_hero_lab': is_hero_lab, |
There was a problem hiding this comment.
is_hero_lab is always true, does it need to be a variable?
| 'sequence_id': sequence_id, | ||
| 'frontfacing_date_id': frontfacing_date_id(date, sequence_id, is_hero_lab), | ||
| 'link': entry.link, | ||
| 'is_hero_lab': False, | ||
| 'is_hero_lab': is_hero_lab, |
There was a problem hiding this comment.
with changes to the shape of the config, we also need to change the type definition. Ideally this should throw an error on runtime? But I'm not that experienced with python types
| @@ -32,7 +32,7 @@ def run(self, version, logs): | |||
| changelog_out = [] | |||
|
|
|||
| for line in changelog_lines: | |||
| if line is None or line == '': | |||
| if line is None or line == '==': | |||
There was a problem hiding this comment.
I thought the changelog json files were to just cover specific changelog pages, such as for individual Heroes, Items etc. I think trying to have it also handle full patch notes is going to become difficult.
We are probably better off leaving those pages to be manual, as they also use extra bits of formatting, such as headings, nested bullets, etc.
| if raw_changelog_id not in self.changelog_configs: | ||
| self.changelog_configs[raw_changelog_id] = { | ||
| 'forum_id': None, | ||
| 'date': date, | ||
| 'sequence_id': sequence_id, | ||
| 'frontfacing_date_id': frontfacing_date_id(date, sequence_id, is_hero_lab), |
There was a problem hiding this comment.
I think label is a simpler name for this
tags.pywere reordered just to change some examples from{{PageRef|Crate|alt_name=crate}}sto{{PageRef|Crate|alt_name=crates}}. While it doesn't really change anything, it does help readability, and improves consistency with ordering in the several lists intags.py.changelog_configsnow has asequence_idthat starts at 0 for each day, designating multiple patches on the same day. This is also used for addingfrontfacing_date_idin the formatMay 3, 2024andMay 3, 2024-1which will be the patch names we use on the wiki.Parsed data in deadlock-data PR