Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save rss changelogs to input data #138

Merged
merged 14 commits into from
Dec 2, 2024

Conversation

hassayag
Copy link
Member

@hassayag hassayag commented Nov 30, 2024

The new fetching process loads input-data/changelogs files first. Any output data is then also written to input data, as input-data is to be treated as a persistent storage - this is handled by the deploy script, in which it commits any input-data changes.

Since the RSS feed can only see recent changelog data, the rest will now be made up by this input-data. Therefore output-data can be consistently reproduced from nothing. Because of that consistency, deadlock-data has been reverted back to the simple data directory, which reflects what output-data would look like locally

Parsed data in deadlock-data PR

@hassayag hassayag linked an issue Nov 30, 2024 that may be closed by this pull request
@hassayag hassayag marked this pull request as draft November 30, 2024 23:06
@Deadbot0 Deadbot0 marked this pull request as ready for review December 1, 2024 00:23
@Deadbot0 Deadbot0 requested a review from Surxe December 1, 2024 00:23
@hassayag hassayag changed the title Bugfix/save rss changelogs to input data fix: save rss changelogs to input data Dec 1, 2024
Copy link
Contributor

@Surxe Surxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have roughly 2 hours of available effort a day due to sickness, so I skimmed very lightly, but this looks very good! Like the idea, even if it means input-data may have slightly more diffs, I think its well worth. Also I like the simplified external calls for changelog fetcher
image

@hassayag hassayag merged commit 6e907f6 into develop Dec 2, 2024
5 checks passed
@hassayag hassayag deleted the bugfix/save-rss-changelogs-to-input-data branch December 2, 2024 23:43
@hassayag hassayag added this to the Changelog Parser milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save rss changelogs to input-data
3 participants