-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dotenv 1.0. #486
Use dotenv 1.0. #486
Conversation
dotenv 1.0 shipped with some good features. Would be great if we could use it with foreman! 👍 |
Could you please make the dependency a bit tighter? Perhaps |
@ddollar Updated. 😀 |
Yes please! 👍 |
So there are two concerns here that I would like to separate:
The former is not something that foreman is going to consider. As mentioned in the project's README foreman should not be installed in an individual app's Gemfile. I don't want to keep doing an upgrade dance to keep Foreman compatible with Rails. For the latter concern what are the new features of dotenv 1.0 that we would be gaining by upgrading? |
Hi @ddollar. I understand your concerns. Thank you for prompt reply. For dotenv 1.0, it fixes a deprecation warnings when using Ruby 2.1 and 2.2. If you are running on Ruby 2.1 or 2.2 with And other improvements for Rails, though. |
Let's do this :) |
I have thought long and hard about this and I'm going to be removing |
I removed foreman from all my apps and install in my system 😉 . Thank you @ddollar, 👍 ! |
Hello!
I want to upgrade my dotenv-rails but it depends on dotenv 1.0.1.
And foreman dpeneds on 0.11.1.
So should we bump dotenv version?
Here is the dotenv changelog: https://github.com/bkeepers/dotenv/blob/master/Changelog.md
Thank you.