Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dotenv 1.0. #486

Closed
wants to merge 1 commit into from
Closed

Use dotenv 1.0. #486

wants to merge 1 commit into from

Conversation

JuanitoFatas
Copy link

Hello!

I want to upgrade my dotenv-rails but it depends on dotenv 1.0.1.

And foreman dpeneds on 0.11.1.

So should we bump dotenv version?

Here is the dotenv changelog: https://github.com/bkeepers/dotenv/blob/master/Changelog.md

Thank you.

@dlackty
Copy link

dlackty commented Oct 5, 2014

dotenv 1.0 shipped with some good features. Would be great if we could use it with foreman! 👍

@ddollar
Copy link
Owner

ddollar commented Oct 5, 2014

Could you please make the dependency a bit tighter? Perhaps ~> 1.0.1

@JuanitoFatas
Copy link
Author

@ddollar Updated. 😀

@KevinBongart
Copy link

Yes please! 👍

@ddollar
Copy link
Owner

ddollar commented Oct 6, 2014

So there are two concerns here that I would like to separate:

  • Maintaining dependency compatibility with Rails
  • New features of dotenv

The former is not something that foreman is going to consider. As mentioned in the project's README foreman should not be installed in an individual app's Gemfile. I don't want to keep doing an upgrade dance to keep Foreman compatible with Rails.

For the latter concern what are the new features of dotenv 1.0 that we would be gaining by upgrading?

@JuanitoFatas
Copy link
Author

Hi @ddollar. I understand your concerns. Thank you for prompt reply.

For dotenv 1.0, it fixes a deprecation warnings when using Ruby 2.1 and 2.2. If you are running on Ruby 2.1 or 2.2 with -w option enabled. There is a deprecation warning for File.exists?. And fix a substitution bug when variable is single quoted.

And other improvements for Rails, though.

@allaire
Copy link

allaire commented Nov 6, 2014

Let's do this :)

@ddollar
Copy link
Owner

ddollar commented Nov 7, 2014

I have thought long and hard about this and I'm going to be removing dotenv from foreman to get off this upgrade treadmill. For now you should install foreman using gem install foreman at the system level rather than putting it into your Gemfiles. Ruby's one-version-per-library policy makes this untenable.

@ddollar ddollar closed this Nov 7, 2014
@JuanitoFatas
Copy link
Author

I removed foreman from all my apps and install in my system 😉 . Thank you @ddollar, 👍 !

@JuanitoFatas JuanitoFatas deleted the patch/dotenv-1-0 branch November 7, 2014 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants