Update Cypress #2622
Merged
Update Cypress #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This repo has @mesosphere-mergebot integration. You can interact with the following commands. |
|
I think you added the |
152a865 to
cd9cf5f
Compare
|
cypress retest |
bfba631 to
e3c1063
Compare
e3c1063 to
b4943f8
Compare
|
Alfred test this |
2 similar comments
|
Alfred test this |
|
Alfred test this |
|
Alfred test this |
Poltergeist
suggested changes
Jan 19, 2018
|
|
||
| // jsdom doesn't calculate |
| @@ -40,10 +40,10 @@ describe("Service Form Modal", function() { | |||
| cy.get(".modal-full-screen").should("to.have.length", 1); | |||
| }); | |||
|
|
|||
| it("Should Autofocus on the Service ID input field", function() { | |||
| it.skip("Should Autofocus on the Service ID input field", function() { | |||
There was a problem hiding this comment.
Why are we skipping this and other Tests?
There was a problem hiding this comment.
Okay got it, cypress-io/cypress#1176 Cypress currently has problems with the focus functionality could you please add a comment here and above all other skipped tests to document why they are skipped.
| @@ -1374,7 +1372,7 @@ describe("Service Form Modal", function() { | |||
|
|
|||
| it('Should add new set of form fields when "Add Environment Variable" link clicked', function() { | |||
| // Key focused | |||
| cy.focused().should("have.attr", "name").and("eq", "env.0.key"); | |||
| // cy.get('.form-control[name="env.0.key"]:focus'); | |||
There was a problem hiding this comment.
If not needed let's remove.
| @@ -1408,7 +1406,7 @@ describe("Service Form Modal", function() { | |||
|
|
|||
| it('Should add new set of form fields when "Add Label" link clicked', function() { | |||
| // Key focused | |||
| cy.focused().should("have.attr", "name").and("eq", "labels.0.key"); | |||
| // cy.get('.form-control[name="labels.0.key"]:focus'); | |||
There was a problem hiding this comment.
No need? Let's trash it!
9b407d3 to
36d0851
Compare
|
@Poltergeist Added the comments 👍 |
DanielMSchmidt
approved these changes
Jan 19, 2018
Poltergeist
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.