Allow an [optional] address to be passed to Titta.init() #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overrides the findAllEyeTrackers() code to specifiy a specific address
dcnieho
reviewed
Jan 22, 2024
| @@ -519,7 +526,7 @@ function setOptions(obj,settings) | |||
| else | |||
| wfunc = @pause; | |||
| end | |||
| while true | |||
| while isempty(address) | |||
There was a problem hiding this comment.
Hmm, i don't think all this logic can be skipped. We need to check the provided eye tracker address connects to an eye tracker of the model set in the settings. also, this while isempty(address) is opaque, even if it would work correctly. I'll be scratching my head later.
To do this right, i need to add something to the mex file. After you fix the other things i'll merge the pull request and then i'll fix up the logic here.
There was a problem hiding this comment.
Right, it would be better to be more careful here 👍🏾
|
I've implemented it slightly differently, currently untested (and mex file is rebuilt only for windows). Will finish it tomorrow. |
|
It should now be ready for use, thanks again for the idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optional parameter overrides the findAllEyeTrackers() code to specifiy a known address