Don't loose signals when no previous method calls have been made. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProxyInterface's listener is dropping signals if the sender does not match an already known name owner for the proxied object. This can occur when no previous method call have been sent to this object, which is always the case for a newly XML-constructed proxy object. Moreover, if the object doesn't expose any method, it is simply impossible to get any signal from it ! In the introspection case, the initial org.freedesktop.Introspectable.Introspect call will always make the name owner initially known to the bus connection. To prevent this, we're getting the name owner during the XML based proxy construction by querying the org.freedesktop.DBus.GetNameOwner method. Fixes dbusjs#86
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProxyInterface's listener is dropping signals if the sender does not match an already known name owner for the proxied object.
This can occur when no previous method call have been sent to this object, which is always the case for a newly XML-constructed proxy object. Moreover, if the object doesn't expose any method, it is simply impossible to get any signal from it !
In the introspection case, the initial org.freedesktop.Introspectable.Introspect call will always make the name owner initially known to the bus connection.
To prevent this, we're getting the name owner during the XML based proxy construction by querying the org.freedesktop.DBus.GetNameOwner method.
Fixes #86