Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ser/de of Value with external (de)serializers #549

Closed
zeenix opened this issue Jan 20, 2024 · 0 comments · Fixed by #974
Closed

Allow ser/de of Value with external (de)serializers #549

zeenix opened this issue Jan 20, 2024 · 0 comments · Fixed by #974
Labels
bug Something isn't working zvariant Issues/PRs related to zvariant crate

Comments

@zeenix
Copy link
Contributor

zeenix commented Jan 20, 2024

While it may not be possible to make the serialized Value look perfect in human-readable formats (e.g JSON), we should still at least try to make it possible to de(serialize) Value. As pointed out here with code example, currently Value fails to deserialize back.

@zeenix zeenix added bug Something isn't working zvariant Issues/PRs related to zvariant crate labels Jan 20, 2024
zeenix added a commit to zeenix/zbus that referenced this issue Sep 4, 2024
This is a test case for dbus2#549 and currently it fails. It's fixed in the
following commit.
zeenix added a commit to zeenix/zbus that referenced this issue Sep 4, 2024
JSON will decode a variant as a map and our `Value`'s `Visitor`
implementation wasn't handling that. This resulted in us not being able
to decode back our own generated JSON in case of variants inside
variants.

Fixes dbus2#549.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working zvariant Issues/PRs related to zvariant crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant