-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: source_db package #280
Conversation
Signed-off-by: Bruno Campos <brunofdcampos@hotmail.com>
Hey @BfdCampos, this one confuses me a bit! I don't really get why you would need to do this - it looks like your goals would be met by using deferral, in particular Because of this, I'm wary of adding it to the package hub as it might get other users into a confusing situation where they inadvertently use this instead of taking advantage of the native functionality Can you tell me more? |
Hi @joellabes, thanks so much for reviewing and reaching out! So this package is designed to dynamically set the database source based on an environment variable. They are useful for conditional database routing but work differently from the defer feature from what I understand from the documentation. The From what I understood, the In summary, the I would also be happy if this feature was taken up by (Anecdotal but the main reason why I even made this PR was because I've already sent the exact copy of the code for the package to 4 friends at different companies because they found it useful, so I thought instead of having to send it manually, why not make it into a package?) |
Works for me! It might be worth adding a bit more of that context to your readme to help folks understand the contexts where it's useful, but let's get this merged! |
Perfect will do now!! Thanks so much @joellabes 🙌🙌 |
@joellabes apologies for the delay. This week has taken the better of me. But I have added the notes to the |
Description
Tell us about your new package!
Link to your package's repository: https://github.com/BfdCampos/source_db/
Checklist
This checklist is a cut down version of the best practices that we have identified as the package hub has grown. Although meeting these checklist items is not a prerequisite to being added to the Hub, we have found that packages which don't conform provide a worse user experience.
First run experience
The README indicates which data warehouses/platforms are expected to work with this packageCustomisability
The package uses ref or source, instead of hard-coding table references.Dependencies
Dependencies on dbt Core
require-dbt-version
range indbt_project.yml
. Example: A package which depends on functionality added in dbt Core 1.2 should set itsrequire-dbt-version
property to[">=1.2.0", "<2.0.0"]
.Dependencies on other packages defined in packages.yml:
Interoperability
The package uses the cross-database macros built into dbt Core where available, such as{{ dbt.except() }}
and{{ dbt.type_string() }}
.users
.Versioning