Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dataproc_batch field for configuring Dataproc Serverless jobs #3661

Conversation

MichaelHeinecke
Copy link
Contributor

Resolves #3382

What are you changing in this pull request and why?

The dataproc_batch config field for configuring Python models running on GCP Dataproc Serverless was added in dbt-labs/dbt-bigquery#578, but it isn't documented yet. This PR adds the missing documentation for this field.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@MichaelHeinecke MichaelHeinecke requested a review from a team as a code owner July 3, 2023 14:29
@welcome
Copy link

welcome bot commented Jul 3, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for docs-getdbt-com ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3cb7556
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64a2e29ee20d25000850074a
😎 Deploy Preview https://deploy-preview-3661--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added new contributor Label for first-time contributors content Improvements or additions to content size: small This change will take 1 to 2 days to address and removed new contributor Label for first-time contributors labels Jul 3, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @MichaelHeinecke , thanks for opening this pr up to resolve issue 3382. this looks good to me, will go ahead and approve + merge ✨

@mirnawong1 mirnawong1 enabled auto-merge July 3, 2023 14:34
auto-merge was automatically disabled July 3, 2023 15:00

Head branch was pushed to by a user without write access

@MichaelHeinecke
Copy link
Contributor Author

@mirnawong1

Thanks for the swift review!

There was a broken link causing the netlify checks to fail - sorry for that. I just fixed that.

Could you please take another look?

@mirnawong1
Copy link
Contributor

hey @MichaelHeinecke thanks for fixing that link up! good to go and merging this for you now ✨

@mirnawong1 mirnawong1 merged commit 041e63d into dbt-labs:current Jul 3, 2023
@MichaelHeinecke MichaelHeinecke deleted the MichaelHeinecke/add_documentation_on_dataproc_batch_field branch July 3, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt-bigquery dataproc_batch config in profiles.yml
2 participants