fix catalog generation #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
LGTM! Tested locally and docs generate works.
To your point in #75, I'm not sure if docs generation broke for dbt-presto (since we didn't need to reimplement get_catalog for Presto). In any event, it'd be a good idea to add docs generate as a step for the Presto branch of integration tests, so I'll do that now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
I never updated catalog generation, but it changed in dbt 0.16.0. This PR fixes
dbt docs generateby making use of dbt 0.16.0's parallel catalog generation.I've also added running
dbt docs generateto the spark integration testing branch.