Leverage "show table extended" for Relation type metadata #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2020
Merged
|
Tested ithis on EMR/Glue data catalog. |
drewbanin
reviewed
Feb 7, 2020
|
|
||
| relations = [] | ||
| quote_policy = { | ||
| 'schema': True, | ||
| 'identifier': True | ||
| } | ||
| for _database, name, _ in results: | ||
| for _database, name, _, information in results: | ||
| rel_type = ('view' if 'Type: VIEW' in information else 'table') |
There was a problem hiding this comment.
we've had issues in the past with other adapters where we assumed that a relation was either of type "table" or "view". In practice, some databases support other relation types, like materialized views or external tables. In this case, I think this logic looks A-OK, but I did want to flag it as something to keep in mind for the future!
drewbanin
reviewed
Feb 11, 2020
drewbanin
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show table extended in ... like '*'statement to get metadata on all relational objects in each database/schema, including theirTypeinformationcolumn result of the statement for the substring'Type: VIEW'. If found in the text result, setrelation.typeto'view', otherwise set to'table'. (I am seeingType: MANAGEDfor tables that dbt creates in Databricks.)Database ... not foundexception if dbt runs the statement for a database that doesn't (yet) exist. I encountered this error after creating a dbt model with a custom schema and executing a dbt commands which did not run that model (e.g.dbt seed).