Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not dropping table for incremental full refresh with delta #287

Merged
merged 9 commits into from
Jul 5, 2022
Merged

Not dropping table for incremental full refresh with delta #287

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7a6b291
Not dropping table for incremental full refresh with delta
grindheim Feb 11, 2022
ca5f39b
Updated changelog
grindheim Feb 11, 2022
fc8579a
Merge branch 'main' of https://github.com/grindheim/dbt-spark into gr…
grindheim May 9, 2022
4f23ca7
Merge branch 'main' into grindheim/UpdateIncrementalFullRefreshDelta
jtcohen6 Jun 15, 2022
42f24f6
Simplified conditional logic according to suggestion
grindheim Jun 28, 2022
d82827a
Updated changelog
grindheim Jun 28, 2022
b8b879f
Only drop table if not delta table
grindheim Jul 4, 2022
df48a0d
Update changelog, trigger CircleCI tests
jtcohen6 Jul 4, 2022
b1daceb
Merge branch 'main' into grindheim/UpdateIncrementalFullRefreshDelta
jtcohen6 Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
## dbt-spark 1.2.0 (April 28, 2022)
## dbt-spark 1.2.0b1 (June 24, 2022)

### Fixes
- `adapter.get_columns_in_relation` (method) and `get_columns_in_relation` (macro) now return identical responses. The previous behavior of `get_columns_in_relation` (macro) is now represented by a new macro, `get_columns_in_relation_raw` ([#354](https://github.com/dbt-labs/dbt-spark/issues/354), [#355](https://github.com/dbt-labs/dbt-spark/pull/355))
- Incremental materialization updated to not drop table first if full refresh for delta lake format, as it already runs _create or replace table_ ([#286](https://github.com/dbt-labs/dbt-spark/issues/286), [#287](https://github.com/dbt-labs/dbt-spark/pull/287/))

### Under the hood
- Add `DBT_INVOCATION_ENV` environment variable to ODBC user agent string ([#366](https://github.com/dbt-labs/dbt-spark/pull/366))

### Contributors
- [@grindheim](https://github.com/grindheim) ([#287](https://github.com/dbt-labs/dbt-spark/pull/287/))

## dbt-spark 1.1.0 (April 28, 2022)

### Features
Expand Down
4 changes: 3 additions & 1 deletion dbt/include/spark/macros/materializations/incremental/incremental.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,11 @@

{{ run_hooks(pre_hooks) }}

{% set is_delta = (file_format == 'delta' and existing_relation.is_delta) %}

{% if existing_relation is none %}
{% set build_sql = create_table_as(False, target_relation, sql) %}
{% elif existing_relation.is_view or full_refresh_mode %}
{% elif existing_relation.is_view or (full_refresh_mode and not is_delta) %}
{% do adapter.drop_relation(existing_relation) %}
{% set build_sql = create_table_as(False, target_relation, sql) %}
{% else %}
Expand Down