Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes the connection properly. #285

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Closes the connection properly. #285

merged 2 commits into from
Feb 15, 2022

Conversation

ueshin
Copy link
Contributor

@ueshin ueshin commented Feb 7, 2022

resolves #280

Description

Closes the connection properly.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

@cla-bot
Copy link

cla-bot bot commented Feb 7, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @ueshin

@cla-bot cla-bot bot added the cla:yes label Feb 10, 2022
@ueshin ueshin marked this pull request as ready for review February 10, 2022 21:23
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ueshin!

@jtcohen6 jtcohen6 merged commit 6c4916b into dbt-labs:main Feb 15, 2022
jtcohen6 pushed a commit that referenced this pull request Feb 15, 2022
* Closes the connection properly.

* CHANGELOG.md
@ueshin ueshin deleted the close_conn branch February 15, 2022 17:15
@ueshin
Copy link
Contributor Author

ueshin commented Feb 15, 2022

@jtcohen6 Thanks!

jtcohen6 added a commit that referenced this pull request Feb 17, 2022
* Closes the connection properly. (#285)

* Closes the connection properly.

* CHANGELOG.md

* Update changelog

* Update CHANGELOG.md

Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com>

Co-authored-by: Takuya UESHIN <ueshin@happy-camper.st>
Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt-spark leaves open connections
2 participants