Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add persist_doc call to incremental model with tests #234

Merged

Conversation

binhnefits
Copy link

@binhnefits binhnefits commented Oct 16, 2021

resolves #

#224

Description

Add persist_docs call to incremental model.
Add incremental_delta_model to tests.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Oct 16, 2021
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution, @binhnefits! LGTM

@jtcohen6 jtcohen6 merged commit 6485ffa into dbt-labs:main Oct 18, 2021
jtcohen6 pushed a commit that referenced this pull request Oct 18, 2021
* add persist_doc call to incremental model with tests

* update changelog

* add whatis to test for incremental
jtcohen6 added a commit that referenced this pull request Oct 18, 2021
* Fix --store-failures (#233)

* Fix --store-failures

* Add chnagelog entry

* Maybe this?

* Fix indentation

* Class inheritance, silly

* Add support for on_schema_change (#229)

* Add support for on_schema_change

* Add changelog note

* add persist_doc call to incremental model with tests (#234)

* add persist_doc call to incremental model with tests

* update changelog

* add whatis to test for incremental

* Reorg changelog

Co-authored-by: Binh Pham <ebinhpham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants