Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcknight/fix python model test #717

Merged
merged 23 commits into from
Aug 1, 2023
Merged

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Aug 1, 2023

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

test_python_my_custom_schema is a currently left hanging artifact in database post ci/cd runs. adding the teardown_method stops this from happening by taking into account the custom schema name of the test the general pytest teardown misses.

will need to backport to 1.3, 1.4, 1.5, and 1.6 to catch all instances of runs.

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 requested a review from a team as a code owner August 1, 2023 19:10
@McKnight-42 McKnight-42 self-assigned this Aug 1, 2023
@McKnight-42 McKnight-42 requested a review from Fleid August 1, 2023 19:10
@cla-bot cla-bot bot added the cla:yes label Aug 1, 2023
@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@McKnight-42 McKnight-42 merged commit c58c54d into main Aug 1, 2023
@McKnight-42 McKnight-42 deleted the mcknight/fix-python-model-test branch August 1, 2023 19:29
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
* update RELEASE_BRANCH env

* add teardown_method to clean up hanging artfiact after test runs

(cherry picked from commit c58c54d)
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
* update RELEASE_BRANCH env

* add teardown_method to clean up hanging artfiact after test runs

(cherry picked from commit c58c54d)
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
* update RELEASE_BRANCH env

* add teardown_method to clean up hanging artfiact after test runs

(cherry picked from commit c58c54d)
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
* update RELEASE_BRANCH env

* add teardown_method to clean up hanging artfiact after test runs

(cherry picked from commit c58c54d)
McKnight-42 added a commit that referenced this pull request Aug 2, 2023
* update RELEASE_BRANCH env

* add teardown_method to clean up hanging artfiact after test runs

(cherry picked from commit c58c54d)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
McKnight-42 added a commit that referenced this pull request Aug 2, 2023
* update RELEASE_BRANCH env

* add teardown_method to clean up hanging artfiact after test runs

(cherry picked from commit c58c54d)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
McKnight-42 added a commit that referenced this pull request Aug 2, 2023
* update RELEASE_BRANCH env

* add teardown_method to clean up hanging artfiact after test runs

(cherry picked from commit c58c54d)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
McKnight-42 added a commit that referenced this pull request Aug 2, 2023
* update RELEASE_BRANCH env

* add teardown_method to clean up hanging artfiact after test runs

(cherry picked from commit c58c54d)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
* update RELEASE_BRANCH env

* add teardown_method to clean up hanging artfiact after test runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants