-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mcknight/fix python model test #717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
mikealfare
approved these changes
Aug 1, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
* update RELEASE_BRANCH env * add teardown_method to clean up hanging artfiact after test runs (cherry picked from commit c58c54d)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
* update RELEASE_BRANCH env * add teardown_method to clean up hanging artfiact after test runs (cherry picked from commit c58c54d)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
* update RELEASE_BRANCH env * add teardown_method to clean up hanging artfiact after test runs (cherry picked from commit c58c54d)
This was referenced Aug 1, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
* update RELEASE_BRANCH env * add teardown_method to clean up hanging artfiact after test runs (cherry picked from commit c58c54d)
McKnight-42
added a commit
that referenced
this pull request
Aug 2, 2023
McKnight-42
added a commit
that referenced
this pull request
Aug 2, 2023
McKnight-42
added a commit
that referenced
this pull request
Aug 2, 2023
McKnight-42
added a commit
that referenced
this pull request
Aug 2, 2023
philippe-boyd-maxa
pushed a commit
to maxa-ai/dbt-snowflake
that referenced
this pull request
Nov 27, 2023
* update RELEASE_BRANCH env * add teardown_method to clean up hanging artfiact after test runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
test_python_my_custom_schema
is a currently left hanging artifact in database post ci/cd runs. adding theteardown_method
stops this from happening by taking into account the custom schema name of the test the general pytest teardown misses.will need to backport to 1.3, 1.4, 1.5, and 1.6 to catch all instances of runs.
Solution
Checklist