[Feature] dbt_clone sf implementation #664
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
|
currently when running the While I like the Base class -> forking Base classes for both scenarios we want to test against think I would like to separate it setup from the stuff found in |
|
@McKnight-42 Separating the tests here from the boilerplate in I'll leave it up to you whether to test the messages or not, but we should test that we get 3 table materializations and 1 view materialization in Snowflake. |
yeah figure once I get these tests working for snowflake I'll go remove the |
…ature/dbt-clone-sf
…ature/dbt-clone-sf
…nowflake into feature/dbt-clone-sf
…ature/dbt-clone-sf
…nowflake into feature/dbt-clone-sf
|
flagging that only failing tests are for |
| from dbt.tests.adapter.dbt_clone.test_dbt_clone import BaseClonePossible | ||
|
|
||
|
|
||
| class TestSnowflakeClonePossible(BaseClonePossible): |
There was a problem hiding this comment.
do we need to test transient and copy_grants?
There was a problem hiding this comment.
this admittedly is more pulled from Jeremey's draft pr where he created a snowflake implementation where he does talk about the use case for transient https://github.com/dbt-labs/dbt-core/pull/7258/files#diff-073e6ed96ac92033f0b921e061b47226b87d4f358350a1ed94fc94165f247b7aR39
while in the docs does mention copy grants
* update RELEASE_BRANCH env * initial implementation of snowflake dbt_clone macros and test design attempts * prove tests throw expected values if expected use caes bases on bool macro * prove tests throw expected values if expected use caes bases on bool macro * start to move towards importing adapter version of test * macro name fix, file rename * change state_relation to defer_relation to match change in dbt-core * change pointer in dev-requirements and add changelog * add clean_up method to drop alt schema names after tests run * change pointer back to main * clone transient table test --------- Co-authored-by: Kshitij Aranke <kshitij.aranke@dbtlabs.com>
resolves #672
Description
adding the macros needed on adapter side for
dbt_cloneand trying to design adapter zone version of Clone tests from defer_state in dbt-labs/dbt-core#7881Checklist
changie newto create a changelog entry