Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement data_type_code_to_name on SnowflakeConnectionManager #484

Merged
merged 11 commits into from
Mar 3, 2023
Merged

implement data_type_code_to_name on SnowflakeConnectionManager #484

merged 11 commits into from
Mar 3, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Feb 23, 2023 •
edited
Loading

resolves #464

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Feb 23, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@MichelleArk MichelleArk marked this pull request as ready for review February 27, 2023 23:09
@MichelleArk MichelleArk requested a review from a team as a code owner February 27, 2023 23:09
MichelleArk
MichelleArk commented Mar 1, 2023
View reviewed changes
@MichelleArk MichelleArk force-pushed the CT-2101/get_column_schema_from_query branch from 2795b1b to 3a9fe86 Compare March 3, 2023 05:14
mikealfare
mikealfare reviewed Mar 3, 2023
View reviewed changes
dbt/adapters/snowflake/connections.py

@classmethod
def data_type_code_to_name(cls, type_code: Union[int, str]) -> str:
assert isinstance(type_code, int)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks mypy!

@MichelleArk MichelleArk changed the title implement data_type_code_to_name on SnowflakeConnectionManager implement data_type_code_to_name on SnowflakeAdapter Mar 3, 2023
@MichelleArk MichelleArk changed the title implement data_type_code_to_name on SnowflakeAdapter implement data_type_code_to_name on SnowflakeConnectionManager Mar 3, 2023
@MichelleArk MichelleArk merged commit d1b6cfe into main Mar 3, 2023
@MichelleArk MichelleArk deleted the CT-2101/get_column_schema_from_query branch March 3, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt colin-rogers-dbt is a code owner automatically assigned from dbt-labs/adapters

@VersusFacit VersusFacit Awaiting requested review from VersusFacit

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2101] Implement get_column_schema_from_query macro
2 participants
@MichelleArk @mikealfare