[CT-1630] Convert column_types test for dbt-snowflake #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est, dev_requirements pin changed
9 tasks
…knight/sf-ct-1630
| @@ -1,3 +1,28 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
can we move this to a fixture file?
There was a problem hiding this comment.
the models? I thought if they were under 50 lines we were keeping them on the same file? but yes can be moved
There was a problem hiding this comment.
I thought the same thing; we want to change our heuristic?
colin-rogers-dbt
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #dbt-labs/dbt-core#6404
Description
convesion of 056 to new functional test method
todo before merge: revert dev_requirements dbt-core pin
Checklist
changie newto create a changelog entry